Search found 21 matches
- January 18th, 2024, 4:57 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Giz just gave us a 5.1 compat change ( https://github.com/axc450/pbs/pull/80/files#diff-8a27174ee1361b52fda12bb789754a7c0a3b921970cd794aeda2eded22cc98c1R89 ) for the badge callback. I don't see this change in extending.txt so figure this is a side effect of Reworked how badges work internally: all b...
- December 19th, 2023, 3:05 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Thanks guys. You led me to wonder if it was a cache issue (when not cached initially, it didn't work; once Safari Hat is cached, it starts to work), and after a test with the user it seems to be the case. I'll have a fix for this next update. Just for sake of confirmation: Deleted cache, was unable...
- December 19th, 2023, 8:07 am
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Is anyone having issues with the Safari Hat Reminder summoning the window but the Safari Hat button is not working reliably? A user is reporting this issue but I can't reproduce it, even with exported options to duplicate settings. I did indeed have this once. Of course I also can't reproduce it an...
- November 8th, 2023, 7:08 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
If you look at the 11 screenshot, the right 1 is thinner than the left one. There seems to be a bias for the right side to suffer more under scaling. In the texture one can see the text being slightly to the right as well which might be the cause. In the end it is a bitmap text, it will always be we...
- November 7th, 2023, 6:41 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Congratulations on the release! I noticed that the existing localisation is gone, so I restored the old ones that still exist. I realise that a lot of strings changed, but at least this is a base and doesn't require people to retranslate existing ones. I'll try to spend a bit of time on deDE in the ...
- November 5th, 2023, 2:03 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
I can add saveMode as third argument for REMATCH_TEAM_OVERWRITTEN when it's fired from a save dialog. There is no saveMode from an import, so it will be nil when it's fired from an import. Will that work? Specifically, line 142 in dialogs/saveDialog.lua: rematch.events:Fire("REMATCH_TEAM_OVERWRITTE...
- November 5th, 2023, 6:22 am
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Rematch.dialog:GetSubject() is intended and it will stay, even if I don't use it yet. It's a good way to get the saveMode (or other context-specific details) of the current dialog. I really don't like guessing that there was a dialog triggering the event and it was the correct one and would very mu...
- November 3rd, 2023, 4:21 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
On the overwrite bit, I'll take a look tonight or tomorrow at latest. I think we are in an okay state here. People probably don't overwrite teams *that* often, and if then scripts being gone is probably okay. I'm not opposed to delaying the release a couple weeks to make sure you guys are comfortab...
- November 3rd, 2023, 9:00 am
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Minor detail: Importing one team opens to that team in the list (since it loads), but importing multiple teams does neither. I understand not loading a random one of them, but was personally confused by the group not expanding. Regarding "TEAM_OVERWRITTEN": "new team id" and "old team id" are mislea...
- October 30th, 2023, 7:17 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Can you add a quick remove/unregister api? I can add one but won't have time to do it until this weekend likely. If you'd like to have something in the meantime, you can make the callback function return false when integration is disabled. You sneaky genius. Take your time with adding the API, it w...
- October 30th, 2023, 4:37 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
I'm a bit scared with people updating only one of our two addons and thus us missing the update event. If Rematch.convert:GetConvertedTeams() returns anything, then an upgrade happened at some point in the past. First return is a table mapping old team key to new teamID. Second return is true if up...
- October 30th, 2023, 10:41 am
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
If you're a Rematch 4 user, the first time you log into Rematch 5, it will make an internal backup of your Rematch 4 teams and settings and then convert everything to Rematch 5. The internal backup will persist for at least as long as the beta lasts. Just to make sure: You will remove the backup fr...
- October 15th, 2023, 7:27 am
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
How is the Pet Battle Scripts project support for Rematch 5 going? More time needed? Ready anytime? I will give a couple weeks warning on this forum before this goes live. (I'm open to other channels to make that announcement too.) I've been massively lacking in energy, so sadly no progress from me...
- August 23rd, 2023, 3:41 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
An update posted tonight to wowinterface has a few changes: Collection summary added which includes a team battle summary tab for all recorded team battles Fix for unique pets count in collection button at topleft of window Updated handling of target names while waiting for them to be cached Search...
- August 21st, 2023, 11:15 am
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
- August 9th, 2023, 9:42 am
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
- Script-button is greyed out If this is for Pet Battle Scripts, I'm not involved in that project sorry. I've created stuff to hopefully make the move to the new version easier, but I don't know its status. Sorry, I've seen your update but didn't have time to work on it yet. For those interested, p...
- July 19th, 2023, 2:50 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
How likely are you to provide such an API? Do you want to toy with it? Import/export strings, needs more research, can't say yet. Including outside data within a rematch.savedTeam[teamID] is...already possible, but it makes me a little nervous that a third-party addon would store data in there. I w...
- July 18th, 2023, 4:40 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
I don't see a reason for us to extend Rematch more than just adding an "edit script"/"add script" button in the context menu and adding the indicator whether a script exists to the team row. Other than that, we only need to hook team editing functions where the custom events might help. Adding a tab...
- July 17th, 2023, 1:15 pm
- Forum: Pet Addons and Macros
- Topic: Rematch 5.0
- Replies: 186
- Views: 945316
Re: Rematch 5.0
Yes, you will keep your old scripts, Only if we manage to map them back to the teams, which is done by name, so should™ be fine. So far I found please don't use https://wow.tools/casc/listfile/download/csv/unverified for allIcons, use https://github.com/wowdev/wow-listfile/raw/master/community-list...
- June 13th, 2021, 8:44 am
- Forum: Pet Addons and Macros
- Topic: Rematch 4.0
- Replies: 707
- Views: 783575
Re: Rematch 4.0
I don't know about tdscript. I don't remember what the icon was that it put on the lists, but 5.0 will be much easier for third party addons to add badges to pet lists, stats to pet cards, and even their own tabs. So whoever works on that shouldn't have any issues. Bad news as the author might not ...