There are actually a few "clear" buttons involved with filters:Iibis wrote:I just noticed a small "inconsistency" or maybe it's just that I'd like them to be exactly the other way around...
If I type something to the search box and then noticed that I have some filters on that are preventing me seeing the correct result, when I clear the filters with the x it also clears the search box (which I rather it did not). If I have something typed to the search box and then apply a filter from the favorite filters, it does not clear the search box. I don't really mind this that much, since the search box can be cleared with its own x, but the first part is something I repeatedly do ("damnit").
I think it's just because I don't categorize search as a filter so I always forget that it's sometimes treated that way?
I don't know how others feel about this?
The one in the search box clears just search.
The one in the typebar clears the current typebar tab (or all tabs if current one currently clear).
Then the one beside the number of pets and involved filters to basically reset everything and display all pets.
I could very easily add an option to exclude Search as a filter cleared by that button. You're right, search is not technically a filter (as seen when saving a favorite filter), just as sort isn't. And sort defaults to not being in the filters when cleared.
In a consistent world, sort and search would both be exempt from that clear button with both having an option to be included in a reset (as sort does now).
To me it feels right to have that button wipe everything, but I'm willing to go with what others feel is best too.
edit: after playing around with this a bit, I'll likely make "Reset Search With Filters" to mirror exactly the behavior of "Reset Sort With Filters". So hitting that reset won't reset search unless this option is checked. It makes the most sense for consistency in both the sort and search not being a part of the actual filter; and having two options do the same thing instead of one doing the opposite of the other. This option will be in a new option header "Pet Filters".
edit2: though there is a problem in that the "results bar" that lists how many pets were found in the search+filters would not show. This isn't a problem for sorts since sorts never remove pets being listed. So I may change my mind. :p